TRB_LaTeX_tex icon indicating copy to clipboard operation
TRB_LaTeX_tex copied to clipboard

Some updates

Open akstrfn opened this issue 5 years ago • 8 comments

  • Restored previous functionality of the counts that was removed when overleaf was added.
  • Added dependency on currfile package to remove requirement to name the file trb_template.
  • Word count file is removed when counting is done.
  • Add line numbers to equation environment.
  • Restore space around equations

akstrfn avatar Jul 23 '19 08:07 akstrfn

@akstrfn thanks for submitting the PR. However, I couldn't get your branch working properly in Overleaf. Have you test it in Overleaf? I want to make sure any updates we make can work properly in both local and server-based environments.

chiehrosswang avatar Jul 23 '19 15:07 chiehrosswang

I don't have overleaf acc. Can you tell me if some useful error is reported? Does overleaf use .latexkmrc or make?

On Tue, Jul 23, 2019, 17:43 Ross Wang [email protected] wrote:

@akstrfn https://github.com/akstrfn thanks for submitting the PR. However, I couldn't get your branch working properly in Overleaf. Have you test it in Overleaf? I want to make sure any updates we make can work properly in both local and server-based environments.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chiehrosswang/TRB_LaTeX_tex/pull/20?email_source=notifications&email_token=ABPAHOWCMEVM2JW6NGQVJ6TQA4RLXA5CNFSM4IGBORW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2TRTMA#issuecomment-514267568, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPAHOVSSB3C4DVKGFJYGQLQA4RLXANCNFSM4IGBORWQ .

akstrfn avatar Jul 23 '19 15:07 akstrfn

I think the error occurs in the \quickwordcount function. It took me a while to get my current master to work both in Overleaf.com and TexStudio on my PC.

I know Overleaf uses latexkmrc, I am using it in the current master.

chiehrosswang avatar Jul 23 '19 16:07 chiehrosswang

For word count, I integrated the method suggested by Sharelatex/Overleaf staff here.

chiehrosswang avatar Jul 23 '19 16:07 chiehrosswang

I've seen that solution but it is a very poor one because it forces everyone into having the same filename just for the sake of Overleaf. It was better if just for overleap the file was named output.tex which should work if I understand the explanation well. If currfile package works in Overleaf I'm not certain what could be the problem.

I think the package should be kept as general as possible and not tuned for Overleaf. The answer you had in your first question is the one that takes care of more corner cases and is much more general, the only problem is the jobname being a compiler switch (which probably most people don't touch). I did a quick search into obtaining a filename and it seemed like its not so easy so maybe some workaround with latexmkrc could do the trick.

akstrfn avatar Jul 23 '19 19:07 akstrfn

Another issue could be removal of the file with rm which should just error but not mess up the compilation but I'm not sure. Can you test this?

akstrfn avatar Jul 23 '19 19:07 akstrfn

I will take a look and test it probably next week - sorry, this week is a bit crazy...

chiehrosswang avatar Jul 24 '19 22:07 chiehrosswang

No rush, take your time.

On Thu, Jul 25, 2019 at 12:12 AM Ross Wang [email protected] wrote:

I will take a look and test it probably next week - sorry, this week is a bit crazy...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chiehrosswang/TRB_LaTeX_tex/pull/20?email_source=notifications&email_token=ABPAHOS3C4NUX4CG7AOL3ZLQBDHTPA5CNFSM4IGBORW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2XYGPI#issuecomment-514818877, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPAHOS7OVHDXYTDOAICKBTQBDHTPANCNFSM4IGBORWQ .

akstrfn avatar Jul 25 '19 08:07 akstrfn