angular-loading-bar icon indicating copy to clipboard operation
angular-loading-bar copied to clipboard

Published 20 hours ago • verified publisher icon chieffancypants

Making angular-loading-bar be aware of 3rd party libraries using XHR requests by listening for events.

Open yagoferrer opened this issue 11 years ago • 10 comments

Added feature: Be able to fire start / end request events from non-angular 3d party libraries that also do XHR requests so that the loading bar it's also aware of these requests.

In case that you are using Angular in combination with non-angular 3d party libraries, you can now fire custom 'cfpLoadingBar:start' and 'cfpLoadingBar:done' request events.

yagoferrer avatar Mar 01 '14 14:03 yagoferrer

This is useful to work with angular.js + oboe.js. It can also be achieved by adding start/done methods. I personally prefer events.

yagoferrer avatar Mar 22 '14 20:03 yagoferrer

this would be really useful for use with the Parse.com javascript SDK!

rbutera avatar Jul 22 '14 23:07 rbutera

Yes please!

matias-sandell avatar Jul 27 '14 17:07 matias-sandell

This seems like a great addition, actually needing it right now.

jturmel avatar Aug 28 '14 17:08 jturmel

+1

ajhodges avatar Oct 15 '14 00:10 ajhodges

Let me give this a little bump +1 Is there any integration that works with parse.com js sdk? I would love to see that :)

cspeer avatar Mar 27 '15 18:03 cspeer

@chieffancypants Are you interested in supporting this feature, if I resolve the merge conflicts?

mattbrunetti avatar Feb 16 '17 21:02 mattbrunetti

I don't use a 3rd party lib that does HTTP requests, I don't think @chieffancypants does either (so the motivation to merge and support this is going to be very low)

Also there are no tests in this PR proving that either the new feature does not break current functionality or that the new feature works as expected

faceleg avatar Feb 16 '17 22:02 faceleg

@faceleg No tests here, true. I can write the tests for the new feature. The existing tests would prove that the new feature doesn't break current functionality, wouldn't they?

I think it's a pretty simple change, so it wouldn't be much extra to support, and it would add a lot of flexibility to this already excellent package. You would be able to use it when the user is waiting for, not just HTTP requests by 3rd party libs, but Web Workers, or requests over WebSockets. I'm sure there are other possibilities too. But it's up to you guys. If you're not interested I can figure something else out.

@faceleg @chieffancypants If I resolve the merge conflicts and add some tests, are you interested in this feature enough that you would review and consider merging?

mattbrunetti avatar Feb 17 '17 15:02 mattbrunetti

@mattbrunetti I'm interested yes

faceleg avatar Feb 19 '17 20:02 faceleg