angular-loading-bar icon indicating copy to clipboard operation
angular-loading-bar copied to clipboard

Published 20 hours ago • verified publisher icon chieffancypants

#113 Build URL to determine if request is cached

Open inkstak opened this issue 8 years ago • 8 comments

In response to #113, I added buildUrlfrom angular to determine if request is cached or not.

inkstak avatar May 09 '16 13:05 inkstak

Needs tests to support new feature

faceleg avatar May 09 '16 20:05 faceleg

Updated, with tests cover.

buildUrl is simple to copy since angular 1.4, because it relays on $httpParamSerializer. Before that, it depends on too many private API, that's why it'll work only with angular 1.4 and later.

inkstak avatar May 11 '16 08:05 inkstak

@chieffancypants over to you

faceleg avatar May 12 '16 01:05 faceleg

+1!

chogarcia avatar Jul 13 '16 10:07 chogarcia

@chieffancypants needs your approval

faceleg avatar Jul 20 '16 09:07 faceleg

Sorry to be so late to the party. For clarification, does this feature simply not work with angular 1.4, or does it break the entire library's compatibility with earlier versions of angular?

chieffancypants avatar Jul 22 '16 18:07 chieffancypants

The feature is available with Angular 1.4 and later (which implements $httpParamSerializer) It doesn't work with earlier versions, but doesn't break anything.

inkstak avatar Jul 22 '16 22:07 inkstak

Hi @chieffancypants Any news about merging ?

inkstak avatar Oct 06 '16 08:10 inkstak