Sergey Rubanov

Results 240 comments of Sergey Rubanov

It would be really confusing if mixed Number and BigDecimal expression will not throw. This can lead to hard to debug errors. Mixed BigInt and BigDecimal expressions make more sense,...

Sorry, "mistake" is a better word. I mean that if developer will mix Number and BigDecimal by mistake, it will be hard to find out if and why the number...

If it’ll be possible to set a number of decimal places via constructor parameter or at least round by some BigDecimal instance method after the cast, then yes

The division in that case becomes very hard since you need to cast BigInt to a Number and sometimes that's not even possible.

@ljharb as far as I understand, @sffc don't propose to make BigDecimals a mantissa + scale pair. Instead, an overloaded form of [`Intl.NumberFormat.prototype.format`](https://github.com/littledan/proposal-bigdecimal/issues/15) is used just for representation.

> Hi, @chicoxyzzy can you assign this issue to me? I am new to open source and I want to solve this issue. Hi @Sarvesh-maker14! First, we need to figure...

In the meantime I encourage you to try battle test our [Contributing Guide](https://github.com/socketsupply/socket/blob/master/CONTRIBUTING.md) and try to build Socket Runtime from sources. Also let me know if something is not clear...

should we update RxJS to 5 version?

> We would probably want to accompany this all with a strong README Sure, I meant it, just did not mention :)