chipy.org icon indicating copy to clipboard operation
chipy.org copied to clipboard

Update Makefile "docker-compose" commands to "docker compose"

Open nickymarino opened this issue 3 years ago • 2 comments

I ran make up and got a message from Docker that docker-compose commands should be moved to docker compose:

$ make up
docker-compose up -d
Docker Compose is now in the Docker CLI, try `docker compose up`

chipyorg_db_1 is up-to-date
chipyorg_web_1 is up-to-date

I get the same message for running a generic docker-compose --help command:

$ docker-compose
Define and run multi-container applications with Docker.

Usage:
  docker-compose [-f <arg>...] [--profile <name>...] [options] [--] [COMMAND] [ARGS...]
  docker-compose -h|--help
...

Docker Compose is now in the Docker CLI, try `docker compose`

Here's the versions of docker-compose and docker I'm using:

$ docker-compose --version
docker-compose version 1.29.0, build 07737305
$ docker --version
Docker version 20.10.5, build 55c4c88

nickymarino avatar Apr 18 '21 00:04 nickymarino

I'd like to wait on this a bit - I'm running Ubuntu 20.04 (current LTS) and the new compose command for the docker CLI is not available yet.

Docker version 20.10.2, build 20.10.2-0 ubuntu1~20.04.2 docker-compose version 1.25.0

Can we do some more research about when the change will take place?

elmq0022 avatar Apr 29 '21 12:04 elmq0022

I thought about this some more. I am in favor of doing this update if we can make the commands used in the Makefile docker version dependent.

The other option I thought of is setting this through an environment variable. We could use docker-compose as the default command and switch to docker compose with an environment variable, maybe CHIPY-DOCKER-COMPOSE.

elmq0022 avatar Apr 30 '21 12:04 elmq0022