circulate icon indicating copy to clipboard operation
circulate copied to clipboard

Display item checkout notices on member's appointment and loan pages

Open jim opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe.

Items in Circulate can have a checkout notice that gives a little information about the item. This often includes things like what other equipment it needs or includes when it is checked out.

Describe the solution you'd like

We'd like to display an item's checkout notice on the appointment and loan pages in the member portal.

The loan page: image

The appointment page: image

jim avatar Jul 13 '21 01:07 jim

Thanks for the Good First Issue label 😄

Here's my first guess, based loosely on items/_details (apologies for the unrealistic/filler text?): image

image

The None. on the Triangle is my best guess for handling null/empty. I also considered

  • omitting the entire line
  • Including "Checkout Notices: but leaving it blank after.

I opted for None. for the explicit "We didn't forget—there's simply nothing to show here" implication.

Questions

Is this kind of what you were thinking? Seeing this, what do you really want? I didn't see any tests that seem to test the UI at this level.

  • Did I miss them?
  • Do you want/need/expect tests for this?

bobmazanec avatar Nov 28 '21 19:11 bobmazanec

Is still issue still relevant and available?

If so, I'd be happy to work on it!

Edit: Could take care of #576 along with it.

florianfelsing avatar Jun 13 '22 17:06 florianfelsing

@florianfelsing I'll assign this one to you!

jim avatar Jun 15 '22 21:06 jim