[BUG] QuickAdd does not respect "New link format" Setting when appending links

[FynnFreyer]

Description

Under Settings → Files & Links, you can set the link format, to e.g. only insert relative links. QuickAdd does not follow this setting and inserts a vault absolute (I think) link instead.

Reproduce

1. Go to Settings → Files & Links
2. Set "New link format" to "relative"
3. Insert a Template with the option "Append link" set
4. Inspect the link, it is not relative

Expected behavior

QuickAdd should honor the "New link format" setting.

Screenshots

New link format is set to relative.

Append link is set.

The inserted (not relative) link.

Additional information

• OS: Fedora 37
• QuickAdd Version: 0.8.0
• Obsidian Version: 1.1.9

If I should provide more debug info, please let me know, also thanks a lot for the great plugin!

[FynnFreyer]

This is super weird btw, because the relevant code (I think) uses Obsidians generateMarkdownLink which should take user preferences into account by default.

if (this.choice.appendLink) {
const markdownLink = this.app.fileManager.generateMarkdownLink(
	file,
	""
);
appendToCurrentLine(markdownLink, this.app);

But the behaviour is still wrong. Maybe something interferes, or it gets the 'relative' link from the vault root, because that's where the working directory is or whatever.

[joellti]

I can confirm this bug is occurring to me as well. Hope a fix is on way. Thx

[chhoumann]

Thank you for the detailed bug report! I can confirm this is a valid issue.

The problem is that when calling generateMarkdownLink(), we're passing an empty string "" as the sourcePath parameter. According to the Obsidian API, this parameter should be the path of the source file (where the link will be inserted). Without this information, Obsidian can't calculate relative paths and defaults to absolute paths.

Took a lot to fix, and there might still be edge-cases to handle. But I've fixed it in #958, which will be available in the next release. Would you be able to test if it works as expected then? Thank you!

[FynnFreyer]

Very cool. Will take a look soon. If you don't hear back, you can assume everything to be working fine for me =D @chhoumann

[chhoumann]

Thank you! Expecting to release 2.6.0 early next week, which will have the fix. :)

[github-actions[bot]]

:tada: This issue has been resolved in version 2.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: