quickadd icon indicating copy to clipboard operation
quickadd copied to clipboard

[BUG] Commands are not updated unless you turn off the command and turn it back on again

Open pjeby opened this issue 3 years ago • 0 comments

Describe the bug Command settings are not updated unless you turn off the command and turn it back on again

To Reproduce Steps to reproduce the behavior:

  1. Create a command from any choice
  2. Change the settings of the choice
  3. Execute the command
  4. Command executes with old settings

Expected behavior Changing the settings for a choice that's a command should reconfigure the command

Desktop (please complete the following information):

  • Windows
  • Obsidian 0.13.23
  • Version 0.4.21

Additional context This could probably be fixed by making the command entries look up choices by the choice.id rather than directly invoking the choice object. (Probably app.commands.removeCommand() should also be used to remove unloaded commands, rather than duplicating its functionality.)

pjeby avatar Feb 04 '22 00:02 pjeby