chg-hou
bugs found:
hello, as a reminder, here are the bugs and other observations I found to be worth reporting.
Running:
-
The Search Settings and SQL Command Preview are not available from Menu and Toolbar. I do not think many people will find these functionality at all, I did just now by accident... With so many different tools, a view menu would help a lot.
-
Some typos in the Menu:
* Setting -> Settings
* Open Setting File Path -> Open Settings File Path *change excluded foldersis, when opened, callededit excluded folders- maybe call it Set Excluded Folders? Define Excluded Folders? Also first letter of words in uppercase would be more consistent. * File and About menu have these ... dots behind the menu items, settings menu does not. At least at Change Excluded Folders and Advanced settings would be appropriate. -
"Device Minor Num" and "Major Num" are so collapsed in default view that I could only see "Device" on both, same as some columns in search results like IsFolder.. The three time columns also are misaligned, and as they always have the same content, they could have a fixed width.
-
[feature request]: Drag&Drop out of the search results would be AWSOME to have ;-)
-
While the information in the table for the partitions is nice, It would be at least cool to have some descriptive mouse-over text which describes what each column is for.
- I for my part have no clue what the minor/major, alias are for..
-
on commandline, I also get "lang file missing: :/lang/en_US.qm"
- the language file for english is not in the lang folder, even if I create one with qtLinguist, it does not find it either... changing Language in the program itself works as expected, so I guess there just a little fix needed here.
-
DawnLightSearch does not respect the current icon-theme, but uses the default kde icons. would be prettier if it did.
-
When I look at the list of devices, it shows two more than I thought it would: /dev/sr0 and /dev/sda2..
My partitions are as flollows:
blkid: /dev/sda1: UUID="..." TYPE="ext4" PTTYPE="dos" PARTUUID="..." /dev/sda5: UUID="" TYPE="swap" PARTUUID="..." /dev/sdb: LABEL="vault" UUID="..." TYPE="ext4"
fdisk: Disk /dev/sda: 60 GiB, 64424509440 bytes, 125829120 sectors Units: sectors of 1 * 512 = 512 bytes Sector size (logical/physical): 512 bytes / 512 bytes I/O size (minimum/optimal): 512 bytes / 512 bytes Disklabel type: dos Disk identifier: ...
Device Boot Start End Sectors Size Id Type /dev/sda1 * 2048 79691775 79689728 38G 83 Linux /dev/sda2 79693822 83884031 4190210 2G 5 Extended /dev/sda5 79693824 83884031 4190208 2G 82 Linux swap / Solaris
Disk /dev/sdb: 164 GiB, 176093659136 bytes, 343932928 sectors Units: sectors of 1 * 512 = 512 bytes Sector size (logical/physical): 512 bytes / 512 bytes I/O size (minimum/optimal): 512 bytes / 512 bytes
So /dev/sda2 is an extended partition, is this intended to be shown in DawnlightSearch? If so, it would be nice to name it as one, otherwise it would be cool to filter it out.
Same with /dev/sr0 as possible CD-RW or similar device.. Its good that it is there as well, but maybe it is a good idea to state that there is no medium in the drive or have a switch where you can hide uncommon stuff / partitions under a certain size by default.
Observations:
- With the AppImage, the icon which is normally shown in the panel, @alt-tab etc.. not working.
- When I compile myself, libsqlite3-dev is missing in the build dependencies list. util-linux (lsblk) in runtime dependencies
- Also, the binary is recognized as a shared library, see here for background info
- Adding QMAKE_LFLAGS += -no-pie to DawnlightSearch.pro fixes that.
Thanks again for creating the QT version, I like it quite a lot!
@revast
- The Search Settings and SQL Command Preview are not available from Menu and
- [x] A view menu has been added.
- Some typos in the Menu.
- [x] Typos corrected.
- "Device Minor Num" and "Major Num" are so collapsed in default view that I could only see "Device" on both, same as some columns in search results like IsFolder.
- [x] Column label modified. You may adjust their widths as you like and the programe is able to save and restore the width settings.
- Drag&Drop out of the search results.
- [x] This feature added. It is realized by a new class named MyQStandardItemModel. The result table also accepts drop actions for debugging purpose.
- Descriptive mouse-over text.
- [x] Tooltips of headers (mouse over text) added to clarify their meanings. The alias column can be edited.
- Lang file missing.
- [x] The translation file location and the corresponding codes changed. Hope it works correctly now.
- Does not respect the current icon-theme.
- [x] I can not find an elegant way to detect the current theme. So a new setting is added (Settings -> Advanced Settings -> Result Table -> Theme Name). You may manully specify another theme which may be located in "/usr/share/icons/".
- Device filter.
- [ ] No change is made by now. We need to discuss this part further. I'd prefer to let users to hide/show partitions without introducing any automatic mechanism. In some case, some one may mount a device with a small size, or search files in a loop device. Currently, users can hide/show partions by right clicking on a database item. By default, "Show All" is checked, and items will be hidden by unchecking it.
- AppImage
- [ ] May I know which linux distribution and desktop environment are you using? Tested in Ubuntu 18.04 (Unity), AppImage works fine.
- Dependencies.
- [x] libsqlite3-dev and util-linux are added to make file and wiki page.
- QMAKE_LFLAGS.
- [x] This flag has been added.
Finally, thanks a lot for your detailed comments.
While the information in the table for the partitions is nice, It would be at least cool to have some descriptive mouse-over text which describes what each column is for.
+1 to this. I have no idea what the little icons mean. Why does one btrfs FS show up as a folder with a red X through it but others show up as disks?
@endolith
+1 to this. I have no idea what the little icons mean. Why does one btrfs FS show up as a folder with a red X through it but others show up as disks?
A folder with a red X means a device that is not mounted. Sorry for this misleading icon. I have changed the mount state icons. Please see device-mounted.svg and device-unmounted.svg .
Hmm, but the device is mounted. Does it have trouble with multi-device pooled btrfs filesystems for some reason?
Hmm, but the device is mounted. Does it have trouble with multi-device pooled btrfs filesystems for some reason?
@endolith That is due to btrfs pooling devices sharing the same UUID. I have added PARTUUID (v0.1.2.4 L107, L135) to distinguish them. Pls check the output of lsblk, only the first device of the multi-device pooled btrfs FS has a valid mount path, which the program uses to detect the mount state. You may delete the old database file, use the new version, and hide the other devices now by right clicking.