Fabian Schmid

Results 34 comments of Fabian Schmid

This PR has been closed by the TB: The person assigned is no longer responsible and in the meantime the new persons responsible have taken on the refactoring or the...

This PR has been closed by the TB: The person assigned is no longer responsible and in the meantime the new persons responsible have taken on the refactoring or the...

Hi @smeyer-ilias As Technical Board, we regularly check for pull requests that have been open for a long time. Any Updates on this? Note, that you can also close this,...

Hi @sashashura Please excuse me very much that your PR - which looks trivial in the first place and includes a security hardening that is very desirable - is taking...

Hi @mjansenDatabay I rebased the PR to avoid conflicts, if there is anything I can do or help feel free to contact me!

Hi @iszmais Yes actually my comment from last time is still relevant, but I that you have pushed something to this. We should look at this together. The `StandardPageBuilder` should...

Hi @iszmais Thank you for your comments and the discussion in https://github.com/iszmais/ILIAS/pull/7. I pushed you two more commits there that we should still include (one is not directly related to...

As a technical board, we regularly check whether pull requests have been open for a long time. Are there any updates on this? Please note that you can also close...

Hi @acgruber may I assign this to you? The changes should be done in other branches (especially release_9 and trunk) as well.

a second `Transformation` for `ISO-8859-1` should be introduced as well to replace `utf8_decode` calls.