Paweł Bylica
Paweł Bylica
> @gumb0 @chfast do we want to specify minimum required compiler versions in cmake/readme? It seems gcc >=8.3 is required unless we want to merge this commit from @gumb0. No.
> Why not? This PR showed that fizzy was not compiling with gcc
Unit tests will be updated later.
Something like this seems ok (just a sketch), but happy to review C API design from other libraries. ```cpp struct FizzyError { int error_code; const char* message; } FizzyError err;...
> However, when it is reusable then subsequent users must check if `err.message` is not null and free it. No. This can be handled inside Fizzy. Only after the last...
Yes, this is useful.
How long does it run?
> How long does it run? It looks like it runs 2x faster than the slowest pairing benchmark. Fine to me then.
Can we finally merge this?
The "normalized" floating point hex literals may work very well for constants.