libchewing icon indicating copy to clipboard operation
libchewing copied to clipboard

add lots of phrases

Open robert501128 opened this issue 9 years ago • 11 comments
trafficstars

Add lots of phrases regarding Issue#184

Regarding the problem @jserv mentioned in Issue#204 I've created a function for more easily adding phrases without breaking sorted sequence.

robert501128 avatar May 01 '16 12:05 robert501128

Coverage Status

Coverage remained the same at 89.498% when pulling 533ec9fc6d5a5285be1964cd4018756855c03b3d on robert501128:master into 5fa23684b0e2270d6ef3de8c9f6b3270f3a52b58 on chewing:master.

coveralls avatar May 01 '16 12:05 coveralls

+胡至強 這個是不是打錯字?胡志強?

hiunnhue avatar May 01 '16 12:05 hiunnhue

You should place the scripts in directory scripts. For example, scripts/lcov.sh.

jserv avatar May 01 '16 13:05 jserv

Maybe we should figure out the good method to add phrases first. https://github.com/chewing/libchewing/pull/197#issuecomment-203315368

PeterDaveHello avatar May 01 '16 13:05 PeterDaveHello

@jserv Do you mean my addPhrase.py or my addPhrase.txt?

robert501128 avatar May 01 '16 13:05 robert501128

I've corrected 胡志強, thanks

robert501128 avatar May 01 '16 14:05 robert501128

Do you mean my addPhrase.py or my addPhrase.txt?

Yes, please use lowercase for consistent naming.

jserv avatar May 01 '16 14:05 jserv

Ok, I've added these.

robert501128 avatar May 02 '16 02:05 robert501128

Coverage Status

Coverage remained the same at 89.498% when pulling c28a7a8bff8d63e5b4b2ba56df907650f8b14cd3 on robert501128:master into 5fa23684b0e2270d6ef3de8c9f6b3270f3a52b58 on chewing:master.

coveralls avatar May 02 '16 03:05 coveralls

Coverage Status

Coverage remained the same at 89.498% when pulling bab6dbc203159114c4fbf0f83b706f1148b56a49 on robert501128:master into 1316c2f2488402b6c2a3f1f896d0682d91070c1d on chewing:master.

coveralls avatar May 02 '16 03:05 coveralls

Coverage Status

Coverage remained the same at 89.498% when pulling 9c6d93ed78f6e16d9ecca8b756f194b9a5d02c91 on robert501128:master into 1316c2f2488402b6c2a3f1f896d0682d91070c1d on chewing:master.

coveralls avatar May 02 '16 03:05 coveralls

I am considering closing this pull request due to the necessity of implementing uniform rules for adding new phrases and adjusting their frequency values. Without these rules, there is a risk of disrupting the current phrasing behavior.

jserv avatar Jan 08 '24 13:01 jserv