libchewing
libchewing copied to clipboard
add lots of phrases
Add lots of phrases regarding Issue#184
Regarding the problem @jserv mentioned in Issue#204 I've created a function for more easily adding phrases without breaking sorted sequence.
Coverage remained the same at 89.498% when pulling 533ec9fc6d5a5285be1964cd4018756855c03b3d on robert501128:master into 5fa23684b0e2270d6ef3de8c9f6b3270f3a52b58 on chewing:master.
+胡至強 這個是不是打錯字?胡志強?
You should place the scripts in directory scripts. For example, scripts/lcov.sh.
Maybe we should figure out the good method to add phrases first. https://github.com/chewing/libchewing/pull/197#issuecomment-203315368
@jserv Do you mean my addPhrase.py or my addPhrase.txt?
I've corrected 胡志強, thanks
Do you mean my addPhrase.py or my addPhrase.txt?
Yes, please use lowercase for consistent naming.
Ok, I've added these.
Coverage remained the same at 89.498% when pulling c28a7a8bff8d63e5b4b2ba56df907650f8b14cd3 on robert501128:master into 5fa23684b0e2270d6ef3de8c9f6b3270f3a52b58 on chewing:master.
Coverage remained the same at 89.498% when pulling bab6dbc203159114c4fbf0f83b706f1148b56a49 on robert501128:master into 1316c2f2488402b6c2a3f1f896d0682d91070c1d on chewing:master.
Coverage remained the same at 89.498% when pulling 9c6d93ed78f6e16d9ecca8b756f194b9a5d02c91 on robert501128:master into 1316c2f2488402b6c2a3f1f896d0682d91070c1d on chewing:master.
I am considering closing this pull request due to the necessity of implementing uniform rules for adding new phrases and adjusting their frequency values. Without these rules, there is a risk of disrupting the current phrasing behavior.