GCViewer icon indicating copy to clipboard operation
GCViewer copied to clipboard

Git error when building without git

Open ekpeters opened this issue 1 year ago • 1 comments

I just grabbed this project off the repo, tried a build with ye olde 'mvn package' and got:

[ERROR] Exception while executing SCM command.: Error while executing command. Error while executing process. Cannot run program "git"

Not a surprise - I don't let build tools at git.

I don't see anything in the instructions for building without git, nor am I keen on granting build tools unfettered access to scm in the modern security realm... I don't do SCM through maven, so if there's an id-10-t easy way to skip it, I don't know it, and frankly, I feel such updates ought to be opt-in, not opt-out, as it can complicate troubleshooting things in development if every build you do updates the code you're trying to troubleshoot.

"Hang on ... why's the instruction pointer on a comment again...  bugger!"

In a development context, updating from SCM ought to be an explicit action, not implicit. To do otherwise invites the 'too many chefs' problem.

Perhaps I'm being unreasonable... whatever. Calling it like I see it, and as I see it.

While I'd prefer to build it myself, the easy alternative is grab the jar from github and cross off any notion of tweaking anything.

ekpeters avatar Nov 20 '24 23:11 ekpeters

@ekpeters You might skip the execution of the buildnumber-maven-plugin.

$ maven -Dmaven.buildNumber.skip=true package
...
[INFO] --- buildnumber-maven-plugin:1.4:create (create-build-metadata) @ gcviewer ---
[INFO] Skipping execution.
...

SubOptimal avatar Dec 03 '24 20:12 SubOptimal