GCViewer icon indicating copy to clipboard operation
GCViewer copied to clipboard

Unable to manage GCViewer log4j logs

Open shay1bz opened this issue 5 years ago • 1 comments

I use GCViewer as a library on a service that monitor and analyzes Spark applications GCs. However the service application logs are filled with INFO logs by GCViewer, which I would like to set to ERROR. https://github.com/chewiebug/GCViewer/blob/e8e26e9fac82b752fa41d3a1de2199427c4a8cf7/src/main/java/com/tagtraum/perf/gcviewer/model/GcResourceFile.java#L26

This ^ makes it impossible, unfortunately. Is there a reason for naming loggers like that? Wouldn't it make more sense to at least use some package name?

shay1bz avatar Mar 05 '19 12:03 shay1bz

Just to be sure: GCViewer does not use log4j, but the  built in java logging framework.

The line in question supports the multi threaded log files loading case. Each file / thread must have its own logger, so that the gui can attach to that logger and show its output.

Since this is an open source library, you may fiddle with the code at your leisure. If you find something suitable, that does not break the current code, you may open a pull request.

Best regards, Jörg

chewiebug avatar Mar 05 '19 21:03 chewiebug