Highlightr-Plugin icon indicating copy to clipboard operation
Highlightr-Plugin copied to clipboard

Highlightr not working in +Obsidian v.15.8 (last update) + other issues

Open gabrielcarus opened this issue 2 years ago • 55 comments

Hey Chetachi! Just leaving some issues on the plugins here, so you can take a look later, take your time to deal with your personal problems, no need to hurry! First of all, congrats on the obsidian plugins, very nice job you did, I can see that you putted much love and effort in every single one of them. Thank you a lot.

Alright, so now the issues:

  • Highlightr stopped working in Obsidian v.15.6 (or superior), even the shortcuts.
    • 7/22/22 - Updated Obsidian to v.15.8, when using the "Ctrl+P" shortcut it works, but the Highlightr pop up don't.
  • An old problem with Highlightr, that I believe you already know, is the space after the marked text. (#39)
  • A small detail, that would be nice to analyze, is that cMenu is taking a lot to load.
  • Snippets plugin didn't stop, but is having some basic bugs in its structure (not making possible to create new CSS Snippets through the plugin and the "hovering" when using the mouse is also bugged).

As I said, take your time alright? That's it, best of luck 🫂


For those having the same problem, in the coments there is a ton of really good solutions. I personally used (not so aesthetic, but is pretty useful) "Wrap with shortcuts plugin $^1$ ", you can configure hotkeys for each highlight color/font color. It won't have rounded highlights, but it can be a good option until Highlightr plugin comes back.

  • The code to highlight in obsidian is: <font style="background-color:#FFBD59A6"> text here </font>
  • The code to make colorful text is: <font style="color:#FFBD59"> text here </font>
  • The letters and numbers after the "#" are the HEX code that indicate a certain color, the "A6" indicate the transparency. You can find good pallete colors in: https://coolors.co/palettes

$^1$ copy and paste on browser: obsidian://show-plugin?id=obsidian-wrap-with-shortcuts

Peace ✌🏻

gabrielcarus avatar Jul 12 '22 22:07 gabrielcarus

Can confirm. This just stopped working for me about 20 minutes ago.

rossoj85 avatar Jul 12 '22 23:07 rossoj85

Confirm. Not working from today.

ikarot avatar Jul 13 '22 18:07 ikarot

confirm

wutsminame avatar Jul 14 '22 06:07 wutsminame

I am so happy I found this post, I thought I was the only one with this issue.

angiedan avatar Jul 15 '22 11:07 angiedan

Isn't working for me either

toroidalGames avatar Jul 17 '22 12:07 toroidalGames

confirm

Xieleilab avatar Jul 19 '22 01:07 Xieleilab

The shortcuts and the right-click menu do not work.

iMagUdspEllr avatar Jul 19 '22 13:07 iMagUdspEllr

Same here. Relieved to find this posting and hope it works again!

greentealatte22 avatar Jul 20 '22 11:07 greentealatte22

Yes confirm, the right-click on highlight don't do anything

sialaweb avatar Jul 22 '22 06:07 sialaweb

confirm here.

WALL-EEEEEEE avatar Jul 23 '22 12:07 WALL-EEEEEEE

Just found this plugin and not working for me, ugh.

NikoMuffin avatar Jul 25 '22 05:07 NikoMuffin

I'm now getting "focus must be in editor"

daamiian avatar Jul 25 '22 19:07 daamiian

FYI, I found a partial work a round -- by setting hotkeys for the various colors, I can now again add highlights. But setting a hot key to open the highlightr doesn't work -- it just doesn't respond, and doesn't display the choice of colors. Also, to unlighlight, right-clicking on the highlight doesn't bring up the unhighlight menu, but raises a note that "focus must be in editor" (I'm using live preview). Clicking on the highlight puts it in edit mode, then right-clicking brings up unhighlight option, and clicking then unhighlights. Hope this may help in troubleshooting. Really like this plugin when it was working normally.

See my post #41

Paddy1058 avatar Jul 25 '22 21:07 Paddy1058

Another workaround for those who don't want to make new hotkeys:

Highlight the word, open command palette, "Highlightr" - pick a color.

This takes longer, but I have enough hotkeys as it is, so this works for me as a temporary solution.

daamiian avatar Jul 26 '22 07:07 daamiian

Any news about that issue ?

CharlesCollin91 avatar Jul 29 '22 17:07 CharlesCollin91

it is not working, +1

KraXen72 avatar Jul 29 '22 21:07 KraXen72

it is not working, +1

zokizuan avatar Jul 30 '22 07:07 zokizuan

Hmm, single keyboard shortcut to a color works for me as a workaround

huyz avatar Jul 30 '22 12:07 huyz

To be clear:

(1) Select text (2) Right click (3) Choose "Highlight" (4) Nadda, nothing, zippo

Control P works fine.

mikelyncheski avatar Jul 30 '22 19:07 mikelyncheski

Still broken on obsidian 0.15.9, highlightr 1.2.1.

jasperdj avatar Jul 31 '22 00:07 jasperdj

I've just installed it yesterday and was struggling for hours. wish I noticed that its no longer available much earlier

ikuygithub avatar Jul 31 '22 14:07 ikuygithub

Its not working for me any more with obsidian 15.6

SimoAbjaou avatar Aug 01 '22 15:08 SimoAbjaou

@chetachiezikeuzor could we please get a fix? thanks

KraXen72 avatar Aug 01 '22 18:08 KraXen72

For a workaround for the broken context menu (for the Desktop app), go to your .obsidian\plugins folder or Settings -> Community Plugins -> Installed Plugins and click the folder icon: image

Go into the highlightr-plugin folder and open main.js. Search for menu.showAtPosition and replace the following:

        menu.showAtPosition({
            x: coords.right + 25,
            y: coords.top + 20,
        });

with

        const orig=menu.__proto__.sort; // Save the original function
        menu.__proto__.sort = function() {}; // Replace the sort function with a no-op function
        menu.showAtPosition({
            x: coords.right + 25,
            y: coords.top + 20,
        });
       menu.__proto__.sort=orig; // Reset the sort function

Basically, the menu.sort function relies on menu items which this plugin just ignores. So, when it hits menu.sort, the dropdown is rebuilt and the dom (which this plugin manipulates) is reset. This change just makes the sort function a no-op.

remerle avatar Aug 02 '22 21:08 remerle

I'd like to confirm this is happening to me as well. The context menu doesn't work, but commands do.

ChriiMoral avatar Aug 04 '22 21:08 ChriiMoral

For a workaround for the broken context menu (for the Desktop app), go to your .obsidian\plugins folder or Settings -> Community Plugins -> Installed Plugins and click the folder icon: image

Go into the highlightr-plugin folder and open main.js. Search for menu.showAtPosition and replace the following:

        menu.showAtPosition({
            x: coords.right + 25,
            y: coords.top + 20,
        });

with

        const orig=menu.__proto__.sort; // Save the original function
        menu.__proto__.sort = function() {}; // Replace the sort function with a no-op function
        menu.showAtPosition({
            x: coords.right + 25,
            y: coords.top + 20,
        });
       menu.__proto__.sort=orig; // Reset the sort function

Basically, the menu.sort function relies on menu items which this plugin just ignores. So, when it hits menu.sort, the dropdown is rebuilt and the dom (which this plugin manipulates) is reset. This change just makes the sort function a no-op.

Tried this, but didn't work. Still getting the same "focus must be in editor error message"

rossoj85 avatar Aug 04 '22 21:08 rossoj85

menu.showAtPosition

According to this method of modification, it works for me, but it needs to be closed once and restart obsidian 2022-08-05_103623

dasu88 avatar Aug 05 '22 02:08 dasu88

Working for me too ! Just got to restart my computer, only restart obsidian didn't work.

CharlesCollin91 avatar Aug 05 '22 17:08 CharlesCollin91

Still no luck on my end...

Seems to be skipping over that menu.shotAtPosition block and going directly to the error message. Logged it out in the console to see what is going on. Anyone else on a Mac? Could that have something to do with it?

image image

rossoj85 avatar Aug 05 '22 22:08 rossoj85

Confirmed working for me. Thank you!

ObsidianTTRPGProject avatar Aug 06 '22 05:08 ObsidianTTRPGProject