minitruco-android icon indicating copy to clipboard operation
minitruco-android copied to clipboard

Published 20 hours ago • verified publisher icon chesterbr

Comments update and method fix.

Open mihailhernandez opened this issue 7 years ago • 2 comments

Comments were changed back to normal on the given by you lines of code. Also the method that you mentioned is actually used a lot in the same class and the return type is fixed to be integer. However, I've managed to do some optimizations on the given method removing all the '.value()' methods in the if statements and calling it in the end of the method, this being the return statement. I hope you like the changes. It would be good if you leave feedback on the work I've done. :)

mihailhernandez avatar Jul 11 '17 20:07 mihailhernandez

@SwiftySwizzy Hello, sorry for taking longer than usual. Is this supposed to replace #11? If so, can you please confirm by closing that one?

chesterbr avatar Jul 31 '17 02:07 chesterbr

Done.

mihailhernandez avatar Jul 31 '17 14:07 mihailhernandez

This became out of sync with the big changes introduced lately, so I'll close for now. Thank you for PR-ing 🙇

chesterbr avatar Feb 14 '23 23:02 chesterbr