docs icon indicating copy to clipboard operation
docs copied to clipboard

fix: mermaid diagram

Open kodaline opened this issue 1 year ago • 10 comments

Fix: reactivating mermaid plugin so that mermaid diagrams are displayed correctly on docs

@nicola-corbellini @sambarza tagging both of you

I have noticed that the issue #190 is due to the commenting of mermaid plugin for mkdocs, I re-added it and tested it locally, the diagram is displayed correctly. I have no idea if the mermaid plugin was commented for some important reasons or it was just an oversight that's why I want to check with you before merging.

kodaline avatar Sep 27 '24 07:09 kodaline

Honestly, I don't remember why it had been commented out. It may be because all the mermaid diagrams had been removed and we forgot this one. I think there should be no problem introducing it back, unless something that I'm not aware of changed recently

nicola-corbellini avatar Sep 27 '24 07:09 nicola-corbellini

Honestly, I don't remember why it had been commented out. It may be because all the mermaid diagrams had been removed and we forgot this one.

Oh ok so do we prefer to remove the diagram?

kodaline avatar Sep 27 '24 07:09 kodaline

Don't know which are the plans, lately. IMHO the diagrams may be helpful, I would even restore the old ones :rofl:

nicola-corbellini avatar Sep 27 '24 15:09 nicola-corbellini

@kodaline @nicola-corbellini I also like the diagrams and pictures, the more the better

pieroit avatar Sep 27 '24 17:09 pieroit

@kodaline @nicola-corbellini I also like the diagrams and pictures, the more the better

so do we want to restore the other diagrams? In case I would use git history to find what is missing

kodaline avatar Sep 30 '24 08:09 kodaline

I propose to reactivate the mermaid plugin in the meantime ;-)

sambarza avatar Oct 03 '24 23:10 sambarza

I propose to reactivate the mermaid plugin in the meantime ;-)

I have checked old versions of the docs but the only flowchart seems to be the one in the issue #190

kodaline avatar Oct 05 '24 10:10 kodaline

Let me check

nicola-corbellini avatar Oct 05 '24 10:10 nicola-corbellini

They are available in this version

nicola-corbellini avatar Oct 05 '24 10:10 nicola-corbellini

They are available in this version

LOL I did not went so much back in time, I expected they were removed around the period the mermaid plugin was deactivated ahah ok I will re-add them, thank you @nicola-corbellini <3

kodaline avatar Oct 05 '24 10:10 kodaline