core icon indicating copy to clipboard operation
core copied to clipboard

lowering recall threshold

Open scicco opened this issue 1 year ago • 4 comments

Description

This is my first attempt to try to contribute a bit to this awesome project😹 This commit will lower the recall threshold. It also separates the config introducing the RecallSettings class as suggested in TODO

I've set the following constant values:

    DEFAULT_K = 3
    DEFAULT_TRESHOLD = 0.5

please let me know if those values are appropriate.

Related to issue (#909)

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas

scicco avatar Sep 16 '24 22:09 scicco

Thx for the contribution! For me is ok but i would prefer to have a central module to store all classes like this one. What do you think @pieroit ?

valentimarco avatar Sep 16 '24 22:09 valentimarco

@scicco sorry for the delay, left some suggestions. Let me know if you can do it or I'll try

pieroit avatar Nov 01 '24 18:11 pieroit

No problem, I'll work on that

scicco avatar Nov 02 '24 18:11 scicco

Hello @pieroit, I've implemented the changes. If something should be changed or fixed, let me know, and I'll do it.

Thank you

scicco avatar Nov 03 '24 21:11 scicco