admin-vue icon indicating copy to clipboard operation
admin-vue copied to clipboard

Logout button

Open pieroit opened this issue 1 year ago • 3 comments

Logout button in the admin should:

  1. delete all cookies*
  2. redirect to /auth/login
  • The login page already deletes cookies, but just to be sure :D

pieroit avatar Sep 19 '24 17:09 pieroit

Where should it be placed?

zAlweNy26 avatar Sep 19 '24 17:09 zAlweNy26

Where should it be placed?

What do you think of something like this?

image

Top right, small circle, and a menu (right now just the user name - instead of undefined - and the logout button)

pieroit avatar Sep 24 '24 14:09 pieroit

it seems nice to me

zAlweNy26 avatar Sep 24 '24 18:09 zAlweNy26

I prefer something like this: image

CC: @kodaline @scicco

zAlweNy26 avatar Oct 09 '24 17:10 zAlweNy26

I prefer something like this

What do you think about this @pieroit @zAlweNy26 ? Not yet fully finished, but I thought about keeping the same style of the bottom left dropdown from where we Upload files/urls, clear conversation etc

Screenshot from 2024-10-09 22-40-15

kodaline avatar Oct 09 '24 20:10 kodaline

I prefer something like this

What do you think about this @pieroit @zAlweNy26 ? Not yet fully finished, but I thought about keeping the same style of the bottom left dropdown from where we Upload files/urls, clear conversation etc

Screenshot from 2024-10-09 22-40-15

Awesome, looks goog to me!

About consistency, in the future we can start wrapping up styles in components and create our own design system. With due relax ;)

pieroit avatar Oct 09 '24 22:10 pieroit

Awesome, looks goog to me!

Screenshot from 2024-10-10 10-58-40

It got some little updates

kodaline avatar Oct 10 '24 08:10 kodaline

I think it should be on the right, not left :)

zAlweNy26 avatar Oct 10 '24 09:10 zAlweNy26

I think it should be on the right, not left :)

do you mean the dropdown menu to be placed on the bottom right of the user icon?

kodaline avatar Oct 10 '24 09:10 kodaline

do you mean the dropdown menu to be placed on the bottom right of the user icon?

No I mean the text, it should be all on the right

zAlweNy26 avatar Oct 10 '24 12:10 zAlweNy26

do you mean the dropdown menu to be placed on the bottom right of the user icon?

No I mean the text, it should be all on the right

Oh ok, when I do it, it looks like this

Screenshot from 2024-10-10 15-03-31 The fact that the line with the username does not align with the text of the other ones is disturbing me XD

Might solve it putting the two icons, theme change and login, on the left before the text? but I don't think I like it, I tried and I confirm that I don't like it XD

kodaline avatar Oct 10 '24 13:10 kodaline

It seems fine to me, just use a different color for the "Signed in as", so to differ from the theme and logout buttons :)

zAlweNy26 avatar Oct 10 '24 13:10 zAlweNy26

hi, maybe splitting signed in as admin and the rest, with some border

-----------------------
   signed in as admin
-----------------------
       Change Theme ☀️
             Logout 🚪
-----------------------

scicco avatar Oct 10 '24 13:10 scicco

It seems fine to me, just use a different color for the "Signed in as", so to differ from the theme and logout buttons :)

Screenshot from 2024-10-10 16-10-42

@scicco I don't know, I will try later on a border just between signed in and the rest, but the others seem too much to me

kodaline avatar Oct 10 '24 15:10 kodaline

@scicco I don't know, I will try later on a border just between signed in and the rest, but the others seem too much to me

yeah other borders are there just because i'm bad with ascii art, i only meant the inner one 😅

scicco avatar Oct 10 '24 16:10 scicco