logstash-input-s3-sns-sqs icon indicating copy to clipboard operation
logstash-input-s3-sns-sqs copied to clipboard

sqs_delete_on_failure defaults to true, docs say default is false

Open hkelley opened this issue 4 years ago • 1 comments

From my logs:

[logstash.inputs.s3snssqs ] config LogStash::Inputs::S3SNSSQS/@sqs_delete_on_failure = true

From lib/logstash/inputs/s3snssqs.rb

config :sqs_delete_on_failure, :validate => :boolean, :default => true

docs:

sqs_delete_on_failure The default value for this setting is FALSE.

hkelley avatar Sep 08 '20 19:09 hkelley

Oh you are right. Probably an copyn´paste failure... Default behaviour is to delete the sqs message if the logprocessor was not able to return in time: https://github.com/cherweg/logstash-input-s3-sns-sqs/blob/480cf2f5a8fab0d8d217ed04f4647c867865095a/lib/logstash/inputs/sqs/poller.rb#L108-L109

I´ll fix this in the docs. regards Christian

christianherweg0807 avatar Sep 09 '20 06:09 christianherweg0807