cheroot icon indicating copy to clipboard operation
cheroot copied to clipboard

Published 20 hours ago • verified publisher icon cherrypy

Zuul CI integration

Open webknjaz opened this issue 4 years ago • 8 comments

❓ I'm submitting a ...

  • [ ] 🐞 bug report
  • [X] 🐣 feature request
  • [ ] ❓ question about the decisions made in the repository

🐞 Is your feature request related to a problem? Please describe.

Not enough CIs. Dogfooding.

🐣 Describe the solution you'd like

Zuul CI integrated. Just checks for now, no gating.

📋 Describe alternatives you've considered

N/A

📋 Additional context

Zuul CI uses CherryPy so naturally, it's interesting to see CherryPy being involved in testing CherryPy. Also, more free test envs never hurts :)

P.S. Folks from vexxhost will provide the CI resources backing this Zuul integration.

webknjaz avatar Mar 03 '20 15:03 webknjaz

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 02 '20 15:05 stale[bot]

@mnaser @noonedeadpunk can we have Zuul run more tests and also trigger it on pushes, not only PRs?

webknjaz avatar May 02 '20 19:05 webknjaz

Hi, yes, I think we can add more tests to zuul - just name them:) Regarding triggering zuul on pushes, despite it's technically possible, it's really highly not recommended, as on push it will be able to check code only after it being merged, while the main point of CI systems it to prevent broken code from being merged.

noonedeadpunk avatar May 19 '20 09:05 noonedeadpunk

Well, this is currently how it works for us. We sometimes push directly or have in-repo branches that we check the status for even before making PRs. So no gating atm.

As for the tests, I guess just run TOXENV=python tox under multiple Pythons.

webknjaz avatar May 19 '20 09:05 webknjaz

So will you enable push builds? It'd be very helpful. We don't need gating right now anyway.

webknjaz avatar May 29 '20 13:05 webknjaz

Sorry, we won't do that, and if you're not going to be looking at using gating, it's hard for us to provide value to you and I would suggest looking at one of the pre-existing CI tools available.

Using Zuul as a simple push-executor is just not the thing it's really meant to be used and loses all of it's value (and also creates a lot more failing jobs that we run for no reason)

mnaser avatar May 29 '20 13:05 mnaser

@mnaser we started getting post_failure statuses from this Zuul instance. Any idea what this means?

webknjaz avatar Aug 13 '20 16:08 webknjaz

Hey @mnaser, it looks like Zuul got completely stuck and stopped even trying to start builds. Any ideas about why that may be happening?

webknjaz avatar Dec 11 '20 20:12 webknjaz