core icon indicating copy to clipboard operation
core copied to clipboard

Update BeamEmissionMultiplet with more accurate MSE calculation

Open Balazs-Peter opened this issue 2 years ago • 1 comments

The spectrum calculation in the current BeamEmissionMultiplet class uses constant line intensity ratios, but in a real situation the ratios also depend on the observation direction. Better intensity ratios, or a method to calculate them might also be available.

Balazs-Peter avatar Feb 27 '23 15:02 Balazs-Peter

Hi @Balazs-Peter, sorry for not replying for so long.

There is a PR #400, which moves the line shape models to a dedicated submodule (see #396). I think it's better to wait for #400 to be merged before creating a PR for BeamEmissionMultiplet.

In terms of implementation, BeamEmissionMultiplet should not have atomic data hard-coded. At the moment, atomic data distributed within Cherab goes to cherab/core/atomic/data, and models access it through the AtomicData interface. Also, I would like BeamEmissionMultiplet to be compatible with Marchuk's data as the most advanced atomic data for MSE at the moment, even if we can't distribute it within Cherab. The latter means that all component ratios (σ10, π23, etc.) must be functions of the beam energy and electron density.

vsnever avatar Apr 12 '23 19:04 vsnever