Tony Chen

Results 66 comments of Tony Chen

It's probably a good idea to allow `nil` in the opts argument, so that `vim.api.nvim_complete(1, matches, {filterfunc=nil})` reverts back to the default behavior of exact prefix matching. As far as...

@oberblastmeister Hm I think I get what you're saying. For me though, I think that the solution (a filterfunc that just returns 1) seems perfectly fine to me, and I...

@tjdevries @bfredl This is ready for review again. I'll squash and rebase after this looks ready to merge, and we've decided on how to address the raised comments.

@tjdevries I think this PR is mostly ready, save for maybe even more tests; I'm just waiting for another round of review from @bfredl , although 0.5 things probably take...

@justinmk Was this more along the lines of what you were thinking?

@bfredl @justinmk Sorry for the multiple pings, but do either of you have time to take a look at this PR and see what it still needs?

@justinmk Do you mind reviewing again? I ended up removing the `exact` keyword, because its behavior can be emulated with a one line function and also partly so the "callable...

The PR as it currently stands is almost ready for merge. However, my current goal is to rework this PR into something that fits in with what I proposed in...

Ping @ii14 @zeertzjq :). Bsd failure looks unrelated?