ng-lottie icon indicating copy to clipboard operation
ng-lottie copied to clipboard

fix(safari): add locationHref to fix clipPath issues in safari

Open damienwebdev opened this issue 6 years ago • 4 comments

Expected Behavior

When I use a lottie animation that has a clipPath with angular, I should expect the same results across browsers.

Current Behavior

In safari, when using an animation that uses clipPath, the mask/clipPath won't apply due to the <base href="/"> that is used by default in angular.

Related issue

In github.com/airbnb/lottie-web - https://github.com/airbnb/lottie-web/issues/914

Fixes #36

Related PRs

https://github.com/airbnb/lottie-web/pull/382

damienwebdev avatar Sep 12 '18 17:09 damienwebdev

@damienwebdev Great find, but why hasn't this been merged yet? @chenqingspring can you please merge this and update the repo?

ydagana avatar Feb 01 '19 21:02 ydagana

@ydagana I think @chenqingspring rarely checks this project, so I'm not sure when we'd get an update.

damienwebdev avatar Feb 01 '19 21:02 damienwebdev

Having the same issue... Anyone found a solution?

jcbreel avatar Apr 23 '19 15:04 jcbreel

I forked the fix of @damienwebdev into a repo with the build files checked in as well. This way you can install it via npm i https://github.com/teamgeist-app/ng-lottie.git and have it work on ios.

But be aware: I WON'T KEEP THE REPO UP TO DATE! SWITCH TO THE ORIGINAL REPO ONCE THE PR IS MERGED

boost-app avatar May 21 '19 13:05 boost-app