Chris Hennes comments

Results 699 comments of


                                            Chris Hennes

UI : Task panels cleanup - Sketcher and Part Design headers

@FreeCAD/design-working-group any comments?

UI : Task panels cleanup - Sketcher and Part Design headers

@marcuspollio can you have a look at that conflict?

Update FindOpenCV.cmake

Is it still necessary for us to provide this file directly? This looks like the OpenCV project directly supports cMake, and that a valid OpenCV installation will include this already.

Changing the workbench's license

I agree with the change.

GSoC 2023: Unified Measurement Facility

@hlorus can you please look at that cMake build error and get it ironed out?

[Problem] Addon Manager detection of git does not work on a Mac

Probably they are not 😄 -- it's a very niche thing to be doing. It's not an overly challenging thing to address (probably low-hanging fruit), just run git and look...

[Problem] Addon Manager detection of git does not work on a Mac

Good find, @luzpaz !! Anyone willing to put together a PR? Probably it should go someplace around here: https://github.com/FreeCAD/FreeCAD/blob/4f1fcbd03b703fb76886c1bbfec172167ea48aef/src/Mod/AddonManager/addonmanager_git.py#L312

[Problem] Addon Manager detection of git does not work on a Mac

Of course, that check should only be done on the Mac 😄

[Problem] Whitespace/Indentation uniformity issues in `src/Mod/Part/App/Geom2d` XML (API) files

Agreed, 4 spaces, no tabs. Note that I think XML auto formatters are likely to give us headaches in the *Py.xml files, where we have many docstrings that won't use...

Does not rely on the pointervalue returned by getNameInDocument() to use as a DAG key.

We discussed this in the meeting this morning and decided to press forward with it. Please ping me if something goes wrong related to it.