rollup-plugin-monaco-editor icon indicating copy to clipboard operation
rollup-plugin-monaco-editor copied to clipboard

Published 20 hours ago • verified publisher icon chengcyber

any chance you can verify this still works ok in recent versions of monaco?

Open NonaSuomy opened this issue 8 months ago • 4 comments

Hi,

Can you verify this still works ok in recent versions of monaco?

Thank you.

NonaSuomy avatar Mar 26 '25 03:03 NonaSuomy

FYI some background on this. ESPHome has been stuck on monaco 0.34.0 for over two years because it uses rollup-plugin-monaco-editor and the readme says 0.34.0 was the last version that was tested. There are a growing demand to upgrade but that statement in the readme is causing a lot of hesitation. If you could spend some time to verify the newer version it would be greatly appreciated.

swoboda1337 avatar Mar 26 '25 14:03 swoboda1337

What are the issues linked to this being a problem for ESPHome?

glmnet avatar Mar 28 '25 12:03 glmnet

What are the issues linked to this being a problem for ESPHome?

@glmnet here is the discussion: https://github.com/esphome/dashboard/pull/654

Three main reason to upgrade:

  • People have reported issues with the editor on Andriod
  • Sticky scroll support
  • Lambda c++ parsing support

swoboda1337 avatar Mar 28 '25 12:03 swoboda1337

FYI I was able to get the unit tests to run with these changes: https://github.com/chengcyber/rollup-plugin-monaco-editor/compare/master...swoboda1337:rollup-plugin-monaco-editor:fix_tests

I am not a web guy but I think those make sense. Everything passes:

Image

swoboda1337 avatar Mar 28 '25 12:03 swoboda1337