Cheng Liu

Results 61 comments of Cheng Liu

@iclanton Changes are made to this PR, including: - all text suggestions are committed - using `isDebug` from `RushCommandLineParser` - handle executeResult - only update `@microsoft/rush-lib` dependency in `package.json` -...

Hi @iclanton , changes applied according to code review - text suggestions - `updateDependencyOnlyExists` renames to `updateDependencyIfItExists` - `rush update` always run even if no package.json modified - refactor `rush...

Wow, I am so impressed by the method to get all active autoinstaller. After a second thought, it seems to me kind of too smart to filter them. Personally, I...

For anyone wants to sneak peek this CLI feature, give [rush-upgrade-self-plugin](https://www.npmjs.com/package/rush-upgrade-self-plugin) a try.

Updates: Feedback at https://github.com/microsoft/rushstack/pull/3554#issuecomment-1331477785, when re-running `rush-pnpm patch-commit ` for the same dependency, the patches folder are not synced to "common/pnpm-patches" folder. I updated the code to handle this case...

> What happens when a command/phase is associated with two remainders? Yes. remainder should be a singleton. We should forbid (throw error) when declaring two remainders for the same command...

> Does this sort the existing `package.json` entries, or does it just insert the new dependency in approximately-correct alphabetical order? If it's the former, we should control this with a...

Hi @kenrick95 > but it seems like it is not handled when it is first implemented in the PR You are right. The initial implementation doesn't cover the advanced syntax,...

Thanks for the great work! but, a little curious about why the documentation is ahead of current version...