safari-download icon indicating copy to clipboard operation
safari-download copied to clipboard

New Function Added : Automatically download all books from Safari Queue

Open bschung5 opened this issue 7 years ago • 3 comments

I added a function that can automatically download all books in the Safari Queue of the user. This batch downloading function reduced the time wasted on manually start new downloading job of another book. Hope you will merge this pull request.

bschung5 avatar Apr 05 '17 18:04 bschung5

Sounds like an interesting feature, let me take a look.

chenditc avatar Apr 06 '17 03:04 chenditc

Any chance having this feature published in the master? I have more than 30 books to be downloaded.

Regards, Thiago

thiagonogueira avatar Jun 15 '17 11:06 thiagonogueira

The major reaeson I didn't merge this pull requests:

"download all books concurently" doesn't sounds like a good idea, espcially when you allow at most 100 books to download at same time. Chrome will fork more than 100 processes to download these books and certainly crash user's computer because they can use a lot of memory. (You can test this out)

chenditc avatar Jun 15 '17 11:06 chenditc