grub4dos icon indicating copy to clipboard operation
grub4dos copied to clipboard

Request: change grub> command prompt

Open steve6375 opened this issue 9 years ago • 5 comments

grub and grub4dos both use the grub> command prompt. This causes confusion when a user reports a boot problem as they often say they are using 'grub' when they are using grub4dos. Could we change the prompt to grub4dos> Would this cause any problems?

steve6375 avatar Dec 16 '15 10:12 steve6375

If you think this is bad idea, shall I Close it to keep things tidy or leave it open?

steve6375 avatar Mar 10 '16 15:03 steve6375

It's really a harmless change..

That string is set in ./configure, line 2704:

PACKAGE='grub'

That single line defines the string in the command prompt. It's used only in stage2/cmdline.c , line 507

  /* Get the command-line with the minimal BASH-like interface.  */
  get_cmdline_str.prompt = (unsigned char*)PACKAGE "> ";

and ./stage2/stage2.c, line 1498 .. as far as I can tell ..

get_cmdline_str.prompt = (unsigned char*)PACKAGE " edit> ";
get_cmdline_str.maxlen = NEW_HEAPSIZE + 1;

wdlkmpx avatar Mar 10 '16 15:03 wdlkmpx

maybe g4dos>

steve6375 avatar Mar 15 '16 19:03 steve6375

Grub4dos is essentially the grub, with extensions. Therefore, changing the prompt is equivalent to adding the version to prompt (e.g. grub0.97> or g4d0.4.4>), while all these information is written on top of the screen (e.g. GRUB4DOS 0.4.4). Thus, changing "grub>" prompt looks unnecessary and ruins the nostalgia of grub>; sorry.

Bahram-Alinezhad avatar Oct 25 '16 21:10 Bahram-Alinezhad

The information is written at the top of the screen, but users still report they are using 'grub' and not grub4dos!!! I think 0.4.6a is now good enough to be 0.4.6c (not Beta any more). It would be good to change the prompt to celebrate the work of chenall and yaya by changing the command prompt and officially release it. If you feel strongly about it, How about a set $prompt variable so we can change the prompt ourselves? Or maybe we can patch grldr to overwrite 'grub>' string?

steve6375 avatar Oct 25 '16 21:10 steve6375