grub4dos
grub4dos copied to clipboard
chenall
cannot use fat copy on some files
I have noticed that 'fat copy' command does not copy some files but has no problem with many other similar files. A test case is attached
Please point me at latest version of fat executable? Seems to work OK if the same file is on the USB drive (not in ISO) (bd)/fat copy (bd)/ocmanage.dll (fd0)/ || pause copy ocmanage.dll failed! is OK. So problem with reading ISO???
Using this modified code in copyFF.g4b, it proves that the problem is nothing to do with the fat utility, because dd also fails on same fails that fat copy fails on (dummy.txt is just a large file). So the problem is reading certain files from inside the ISO. Some are OK but others are not!
::copy file
echo FILE=%FD%%%cd%/%1
debug 1
#dd if=(bd)/dummy.txt of=(bd)/dummy.txt || echo Error: dd failed on dummy test
dd if=()/%1 of=(bd)/dummy.txt > nul || echo **** ERROR dd failed on %cd%/%1 - dd if=()/%1 of=(bd)/dummy.txt
fat copy ()/%1 %FD%%%cd%/ > nul || echo **** ERROR FAT %cd%/%1
echo -----------------------------
pause
shift
goto :copyfiles
dummy.txt already exists. You can see it works for ocmanager.dll and setup.exe, but not for some other files.
Any progress please? This seems to be a bug in grub4dos? Can you reproduce the issue using the test case I uploaded?
Fat may have problems. DD no problem.
::copy file echo dd if=()%%cd%/%1 of=()/1.txt dd if=()%%cd%/%1 of=()/dummy.txt > nul || pause ERROR - dd if=()%%cd%/%1 of=()/dummy.txt shift goto :copyfiles
Yes sorry bad code It is just fat problem but if copy same file from (hd0,0)/ocmanage.dll then it works. So problem is when copying file from inside an ISO???
If I rename ocmanage.dll to rcmanage.dll then works. If I rename setup.exe to ocmanage.dll inside ISO then it fails. So it is the file name that has a problem.
FAT no problem.
::copy file echo fat copy ()%cd%/%1 %FD%%%cd%/ fat copy ()%cd%/%1 %FD%%%cd%/ > nul || pause Error: copy ()%cd%/%1 %FD%%%cd%/ shift goto :copyfiles
Try this code: it just copies the same file in two different ways why does it work for some files but not other flles??? I test for full path after copy and delete file before 2nd copy.
set C1=
set C2=
fat copy ()%cd%/%1 %FD%%%cd%/ > nul || set C1=1
if exist C1 echo ERROR1: copy ()%cd%/%1 %FD%%%cd%/ || echo OK1 : copy ()%cd%/%1 %FD%%%cd%/
if not exist %FD%%%cd%/%1 echo COPY1 FAILED
fat del %FD%%%cd%/%1 > nul
fat copy /%1 %FD%%%cd%/ || set C2=1
if exist C2 echo ERROR2: %cd%/%1 || echo OK2 : copy /%1 %FD%%%cd%/
if not exist %FD%%%cd%/%1 echo COPY2 FAILED
shift
goto :copyfiles
This example would like to explain what?
- fat copy ()%cd%/%1 %FD%%%cd%/ > nul || set C1=1 Copy oracle.cab success .
- You delete the oracle.cab.
- fat copy /%1 %FD%%%cd%/ || set C2=1 Copy oracle.cab fail. Tell you that oracle.cab does not exist.
Don't forget, the previous copy of the successful oracle.cab , has been deleted by you ,
If you look at the screenshot, you can see that many files are copied OK (preload.exe, etc. etc.). Only certain files fail to copy.
The root is set to the /add-ons/pws directory, so both forms of the 'fat copy' command should work (and do work for many files in same directory - but not all files!). You can see that both 'fat copy' commands work for many files, but not for some files e.g. ocmanage.dll and oracle.cab. I have proved that it is the file name that is the problem, if I rename ocmanage,dll to setup.exe inside the ISO, and rename setup.exe to ocmanage.dll, then ocmanage.dll still fails (which is really setup.exe). So it is the file name that is causing the problem.
If I rename ocmanage.dll to rcmanage.dll (inside the ISO and save new ISO) then works. So it is not the length of the file name. If I rename rcmanage.dll back to ocmanage.dll and re-save the ISO, then it fails again!
How FAT works, I don't know. however : fat copy ()%cd%/%1 %FD%%%cd%/ OK! fat copy /%1 %FD%%%cd%/ fail!
FAT has a parameter '/o' ,Problem by it . use:
- fat copy ()%cd%/%1 %FD%%%cd%/
- fat copy //%1 %FD%%%cd%/
Yes! I can't believe I didn't spot that only files beginning with o had a problem! So it is a bug in fat.c. if (memcmp(arg, "/o", 2) == 0) change to... if (memcmp(arg, " /o ", 4) == 0)
Then it will only fail if there is a file called o or is there a better fix?