Bright Chen comments

Results 217 comments of


                                            Bright Chen

Memory leak?

Thanks for the feedback. I will optimize the implementation and solve the memory leak problem later.

Prefer use logging in butil or glog?

I currently use `butil/logging` in production, which was the impetus for implementing asynchronous logging in `butil/logging`. I believe that a subset of users use `butil/logging`. I have plans to support...

Prefer use logging in butil or glog?

What are the problems with the integration through `LogSink`?

Prefer use logging in butil or glog?

Make LogStream a virtual base class as follows: ```c++ class LogStream : public std::ostream { LogStream(std::streambuf* streambuf) : std::ostream(&streambuf) {} virtual void SetSourceLocation(const SourceLocation& sl) = 0; virtual void Flush()...

about support protobuf arena

> 请问这个pr没合入是还存在什么问题么？ @limindlmu 可以看看#2751 。

about support protobuf arena

Closed this as completed #2751 .

sizeof(Butex) == BAIDU_CACHELINE_SIZE static assertion failed

https://github.com/apache/brpc/blob/f642491996b675496330cdd611fc764bd4b80ac7/Makefile#L25 BTHREAD_USE_FAST_PTHREAD_MUTEX is defined by default in makefile.

could brpc make IdTraits::MAX_ENTRIES/INIT_GC_SIZE a configurable option?

CC @stdpain

第三方库版本依赖，以及系统依赖

https://github.com/apache/brpc/blob/master/docs/cn/getting_started.md#%E6%94%AF%E6%8C%81%E7%9A%84%E4%BE%9D%E8%B5%96

grpc H2UnsentResponse LeakSanitizer: detected memory leaks

https://github.com/apache/brpc/blob/d3c68546ec3973e03656c6129d8f17e0198a5824/src/brpc/policy/http2_rpc_protocol.cpp#L1687-L1691 https://github.com/apache/brpc/blob/d3c68546ec3973e03656c6129d8f17e0198a5824/src/brpc/policy/http2_rpc_protocol.cpp#L1672-L1678 在Socket里会调`AppendAndDestroySelf`回收的。压测场景下，出现内存泄漏，应该不止泄漏几百bytes吧。是不是进程退出的时候，server还在处理请求呢？