videojs-chapter-thumbnails icon indicating copy to clipboard operation
videojs-chapter-thumbnails copied to clipboard

Published 20 hours ago • verified publisher icon chemoish

Calling addRemoteTextTrack without explicitly setting the manualCleanup parameter to true is deprecated

Open aarvay opened this issue 7 years ago • 2 comments

Getting this error with the latest version of videojs

aarvay avatar Mar 03 '17 13:03 aarvay

@aarvay thanks, some reason I am still not getting notifications for this repo.

I am going to fix this deprecation and set it to false.

I am going to be introducing a breaking change due to the move to emulated text tracks. Going to test this a bit before I do, but let me know if there are any other issues.

https://github.com/chemoish/videojs-chapter-thumbnails/pull/25

Previously, you could get the track off the cue, but now you cannot—so I am leveraging the options so you have access to the same information.

chemoish avatar Apr 04 '17 22:04 chemoish

Addressed by https://github.com/chemoish/videojs-chapter-thumbnails/pull/24. (https://github.com/chemoish/videojs-chapter-thumbnails/pull/24/files#diff-fbb30ecff4501db25861e34c3a6b81e4R114)

chemoish avatar Apr 04 '17 23:04 chemoish