feat: migrate form to tanstack & zod
Deploying nmrium with
Cloudflare Pages
| Latest commit: |
da0df6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e7a7db6.nmrium.pages.dev |
| Branch Preview URL: | https://3809-start-using-tanstack-fo.nmrium.pages.dev |
The form now look like that with react-science components :
Validation should not accept an empty string.
Layout is not ok, please make sure it looks as nice as before.
Do you want it to looks like this ?
Do you want it to looks like this ?
Not strictly. But the previous layout had a fixed width which made much more sense.
Regarding button color, I don't know on what ground you changed the button color. Ok if it is for consistency reasons, but otherwise keep the original green color.
@Sebastien-Ahkrin It seems you forgot this PR.
Is this looking better ? @stropitek
If we want the label text to not be centered, we have to change the react-science components
Why is it centered?
Why is it centered?
NVM its because i use DialogContent, i can change the behavior. its now done
DialogContent is centered by default?
DialogContent is centered by default?
yep it looks like that
I see that DialogContent is a component defined in this file and only used here. I don't understand why you override the value instead of changing the component directly.
Now I think we should entirely remove this component and just render DialogBody.
Previously, the input element was auto-focused. Now with the refactor it is not anymore.
Probably related to react-science, but I don't think the help message should be red. Only the error message.
![]()
Yep, to set the error / text message in other color, i have to change react-science. Same for auto-focus, i should change the behavior in react-science.