Viacheslav Ostrovskiy comments

Results 20 comments of


                                            Viacheslav Ostrovskiy

Using HasRelationshipObservables trait in multiple models causes double events to be fired in tests

ping @BoyeMagnus

Using HasRelationshipObservables trait in multiple models causes double events to be fired in tests

@BoyeMagnus sorry for the huge delay, working on MVP project for days and nights 🤯 I would accept PR with described changes with provided tests if you have a little...

feat: fetch relationship observables recursively

Thanks for the PR, @sWalbrun ! Could you explain, how do you use inheritances in your projects? What if you would like to use traits in your base model and...

New package to replace this one

@coleshirley, you are welcome, that's open source package, you may use it as you like 🤷‍♂️

Include parent class observable traits in child class

@kbasten could you add tests?

Chance for listeners (belongsToMany, MorphTo)

First of all thanks for the contribution. Could you explain why should we break compatibility with native relation methods?

Chance for listeners (belongsToMany, MorphTo)

Well, now i see what your PR about. I have to think about it.

Chance for listeners (belongsToMany, MorphTo)

Hi, @Volga! Going to merge your PR, but need to make some additional test and reflect this change in docs, but currently have enough time to do it :( Hope...

Chance for listeners (belongsToMany, MorphTo)

Added couple comments for your PR. Also i would like to ask about other relations, shouldn't we provide such logic for methods in other relations?

feat: fetch relationship observables recursively

No activity from author