Alex
Alex
I've fixed that with the following custom fixture, please let me know if it worth a PR ```py3 import logging from pytest_catchlog import LogCaptureFixture class CustomLogCaptureFixture(LogCaptureFixture): def __init__(self, item, monkeypatch):...
Have no idea why pypy3 tests fail, they are broken in master. Regards 2.6 tests failure - I have two options: 1. Have if statement with some fix only for...
Drive by comment - I can confirm that I had the same issue with GTX 1080 Ti, and the nightly build shared in https://github.com/alvr-org/ALVR/issues/2064#issuecomment-2056413327 resolved it for me. Thank you...
> It is no longer possible to change the STATS_CLASS from the spider at this point. as well as LOG_LEVEL and LOG_FORMATTER. don't thinks they are often changed from spider...
> In other words, why does crawler need a logger and stats as soon as it is initialized? @kmike One thing which looks important to me - setup logging before...
Yes, but it we keep logging setup before `Spider.__init__` - we cannot change LOG_LEVEL and LOG_FORMATTER from spider. If we move logging setup after `Spider.__init__` - we can change those...
Another option is to do better job in separating "core" settings which must not be changed by spider from extensions/middlewares/pipelines/addons settings that can be changed by spider.
> some settings being unchangeable from the spider sounds ok if we document this properly > a little backwards incompatibility (Crawler.extensions not available after Crawler.**init**()) sounds ok as well -...
Same issue here. Python 3.5, when I use LogstashFormatter with FileHandler I get: ``` --- Logging error --- Traceback (most recent call last): File "/usr/local/lib/python3.5/logging/__init__.py", line 982, in emit stream.write(msg)...
Tests fail because of https://github.com/pypa/setuptools/issues/951, probably should be fixed in another PR