py-motmetrics icon indicating copy to clipboard operation
py-motmetrics copied to clipboard

Get ride of np.bool deprecation warning.

Open alexlitz opened this issue 3 years ago • 3 comments

Missed another DeprecationWarning with the last one.

alexlitz avatar Feb 21 '22 17:02 alexlitz

@alexlitz did you see my code comment about public API concern?

cheind avatar Feb 23 '22 07:02 cheind

@cheind no, I do not see a comment about that.

alexlitz avatar Feb 23 '22 20:02 alexlitz

Here https://github.com/cheind/py-motmetrics/pull/155/files/fc06cd2e66c57250d1322457b59a52232c951ee4

cheind avatar Feb 26 '22 07:02 cheind

@cheind @alexlitz Please see issue https://github.com/cheind/py-motmetrics/issues/172, I believe merging this PR is pretty urgent.

facundo-lezama avatar Dec 23 '22 15:12 facundo-lezama

@facundo-lezama thanks for pointing this out!

cheind avatar Dec 23 '22 15:12 cheind

I've found that bool_ is part of the public API here https://numpy.org/doc/stable/user/basics.types.html

So I will merge this to develop.

cheind avatar Dec 23 '22 15:12 cheind