esp32-usbip-poc icon indicating copy to clipboard operation
esp32-usbip-poc copied to clipboard

import data not filled correctly

Open kdg3737 opened this issue 2 months ago • 1 comments

Hi Chegewara,

I think I found a bug in your fill_import_data method in uspbip.cpp. The idVendor, idProduct and bcdDevice fields are copied over to the 'devlist_data' object instead of 'import_data':

    devlist_data.idVendor = __bswap_16(dev_desc->idVendor);
    devlist_data.idProduct = __bswap_16(dev_desc->idProduct);
    devlist_data.bcdDevice = __bswap_16(dev_desc->bcdDevice);

should be:

    import_data.idVendor = __bswap_16(dev_desc->idVendor);
    import_data.idProduct = __bswap_16(dev_desc->idProduct);
    import_data.bcdDevice = __bswap_16(dev_desc->bcdDevice);

Just thought I'd let you know.

Thanks for making this very useful poc.

Kris

kdg3737 avatar Apr 11 '24 08:04 kdg3737

Hi, its probably just copy/paste bug.

Thanks

chegewara avatar Apr 11 '24 12:04 chegewara