supermarket icon indicating copy to clipboard operation
supermarket copied to clipboard

Remove the Supermarket 'Version Tag Metric' metric

Open tas50 opened this issue 3 years ago • 3 comments

This is something we should check in Cookstyle instead. Once #2181 is complete we should remove this metric.

tas50 avatar Aug 24 '21 21:08 tas50

We need to remove this metric.

Screenshot 2022-01-03 at 6.49.48 PM.png

saghoshprogress avatar Jan 03 '22 13:01 saghoshprogress

We need to verify the same Metric in cookstyle PR before we remove this Metric.

@sanga1794 , @msys-sgarg Please check and confirm

saghoshprogress avatar Jan 03 '22 13:01 saghoshprogress

@skkprogress @tas50

  • Version Tag metric is not only taking care of version tag in metadata.rb but also is checking whether attribute source_url is present in metadata or not , also it should be containing valid github url value.. We display failure - Failure: To pass this metric, your cookbook metadata must include a source url, the source url must be in the form of https://github.com/user/repo, and your repo must include a tag that matches this cookbook version number like this in case of invalid source_url.

  • Also, cookstyle will not cover the case where version tag is missing altogether .. only if version tag is present and contains an invalid version cookstyle will throw an error

Please let me know if still version tag metric is ok to be removed ?

msys-sgarg avatar Jan 27 '22 13:01 msys-sgarg