supermarket
supermarket copied to clipboard
chef
Quality metrics: accept cookbooks hosted on https://gitlab.com
The following metrics enforce an url linking to github.com:
- Contributing File Metric
- Testing File Metric
- Version Tag Metric
Thus they fail on a cookbook hosted on gitlab.com like https://supermarket.chef.io/cookbooks/confluent-platform#quality. Alternative git platforms should be allowed like https://gitlab.com.
Thanks.
@s-bernard Certainly can be considered.
Current source_url usage over 3,769 cookbooks:
| Count | Source URL Domain |
|---|---|
| 2642 | github.com |
| 44 | gitlab.com |
| 34 | scm.osdn.jp |
| 13 | bitbucket.org |
| 3 | fnichol.github.com |
| 3 | www.github.com |
| 3 | github.alaska.edu |
| 2 | fnichol.github.io |
| 2 | www.rackspace.com |
| 1 | phlippers.net |
| 1 | www.sonarsource.org |
| 1 | ccsl.ime.usp.br |
| 1 | www.likewiseopen.org |
| 1 | www.princexml.com |
| 1 | bbg-cookbooks.github.io |
| 1 | git.corujalab.com.br |
| 1 | humdi.net |
| 1 | app.copperegg.com |
| 1 | j.mp |
| 1 | git.openstack.org |
| 1 | vkhatri.github.io |
Some back of the envelope notes about the effort:
- Probably involves adding the https://github.com/NARKOZ/gitlab client to Supermarket's fieri engine.
- Fieri engine's
SourceRepoWorkerwould use the gitlab client and would need to get smarter about differentiating between types of source repositories. - As you have identified, the three metrics—contributing file, testing file, and version tag—would get updated to check for presence of files/tags via the appropriate client.
There will be some noodling required in figuring out how to abstract the act of checking for the existence of a tag or a file across the two different client APIs.
It would be a great idea to support Gitlab because of its free, built-in CI/CD - it is a great way to control the quality of the cookbook in each commit. I guess more and more cookbooks will come from Gitlab...
