ohai icon indicating copy to clipboard operation
ohai copied to clipboard

FreeBSD: Skip inet6 addresses matching ::1

Open feld opened this issue 1 year ago • 2 comments

Fixes #1835

feld avatar Sep 11 '24 19:09 feld

@feld please add DCO

tpowell-progress avatar Oct 01 '24 20:10 tpowell-progress

After writing https://github.com/chef/ohai/pull/1841 I THINK I know what the problem is here.

FreeBSD reports no scope for global addresses. Further, it uses scopeIDs, not scopes, so the sorting that happens here doesn't work at all.

So the right fix here is to modify this code to:

  1. Convert scopeIds into scope names
  2. If no scopeID is there, just set it to 'global' which seems to be what FreeBSD is assuming.

jaymzh avatar Oct 22 '24 22:10 jaymzh

@feld - ping?

jaymzh avatar Nov 05 '24 20:11 jaymzh

@feld following up

tpowell-progress avatar Nov 19 '24 21:11 tpowell-progress

@dafyddcrosby wants to look at this - will wait to close.

jaymzh avatar Nov 26 '24 21:11 jaymzh

@dafyddcrosby wants to look at this - will wait to close.

If If I haven't tested this by December 3rd's community PR review (or if @feld responds), can close then

dafyddcrosby avatar Nov 26 '24 21:11 dafyddcrosby

@dafyddcrosby wants to look at this - will wait to close.

If If I haven't tested this by December 3rd's community PR review (or if @feld responds), can close then

@jaymzh Didn't get time over the weekend, and don't know when I will in the next few weeks, so let's close for now.

dafyddcrosby avatar Dec 03 '24 14:12 dafyddcrosby

Closing due to no response from original author.

jaymzh avatar Dec 03 '24 17:12 jaymzh