ohai icon indicating copy to clipboard operation
ohai copied to clipboard

Future Ohai: Remove legacy data in the Virtualization plugin

Open tas50 opened this issue 7 years ago • 2 comments

Before we introduced node['virtualization']['systems'] we used node['virtualization']['system'] and node['virtualization']['role']. This only allowed for a single virtualization, but we detected multiple technologies so the last writer won. We introduced the systems array in Chef 11 (pretty sure) which provides a much more reliable way to detect virtualization systems. We should create a Foodcritic rule and move people to the new system so we can fully deprecate the less than ideal older interface.

Scenario where the old interfaces fail:

virtualization
    systems
        kvm: host
        vmware: host
    system: vmware
    role: guest

tas50 avatar Jan 30 '18 00:01 tas50

@tas50 is there a cookstyle rule for this?

btm avatar Mar 30 '20 21:03 btm

There is not. We probably need to have a rule in place for a while before we can consider removing anything.

tas50 avatar Mar 30 '20 22:03 tas50