knife-tidy
knife-tidy copied to clipboard
Fix generate_new_metadata in tidy_backup_clean.rb needs to preserve metadata.json.
Signed-off-by: Vasu1105 [email protected]
Description
It skips the new generation of files if both metadata.json and metadata.rb exist It raises error if both metadata.json or metadata.rb does not exist It creates metadata.json if only metadata.rb exist as knife cookbook metadata does.
Issues Resolved
Fixes #105
Check List
- [ ] New functionality includes tests
- [ ] All tests pass
- [ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
- [ ] PR title is a worthy inclusion in the CHANGELOG
@lamont-granquist could you please review this PR. Most of this comments https://github.com/chef/knife-tidy/issues/105#issuecomment-540338069 are incorporated here.
@Vasu1105 Can you rebase this please?
@Vasu1105 Can you rebase this please?
@tas50 Done.
@PrajaktaPurohit this could also use review
@lamont-granquist since you reported this issue do you wanna review this?