knife-tidy icon indicating copy to clipboard operation
knife-tidy copied to clipboard

Fix generate_new_metadata in tidy_backup_clean.rb needs to preserve metadata.json.

Open Vasu1105 opened this issue 6 years ago • 5 comments

Signed-off-by: Vasu1105 [email protected]

Description

It skips the new generation of files if both metadata.json and metadata.rb exist It raises error if both metadata.json or metadata.rb does not exist It creates metadata.json if only metadata.rb exist as knife cookbook metadata does.

Issues Resolved

Fixes #105

Check List

Vasu1105 avatar Oct 11 '19 11:10 Vasu1105

@lamont-granquist could you please review this PR. Most of this comments https://github.com/chef/knife-tidy/issues/105#issuecomment-540338069 are incorporated here.

Vasu1105 avatar Mar 16 '20 06:03 Vasu1105

@Vasu1105 Can you rebase this please?

tas50 avatar Jun 11 '20 20:06 tas50

@Vasu1105 Can you rebase this please?

@tas50 Done.

Vasu1105 avatar Jun 12 '20 04:06 Vasu1105

@PrajaktaPurohit this could also use review

tas50 avatar Feb 26 '22 01:02 tas50

@lamont-granquist since you reported this issue do you wanna review this?

tas50 avatar Feb 26 '22 01:02 tas50