Chefstyle fixes to unblock releases cookstyle

[tas50]

Description

This PR was requested in https://github.com/chef/cookstyle/pull/981

Related Issue

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• [ ] I have read the CONTRIBUTING document.
• [ ] I have run the pre-merge tests locally and they pass.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [ ] If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
• [ ] All new and existing tests passed.
• [ ] All commits have been signed-off for the Developer Certificate of Origin.

[netlify[bot]]

👷 Deploy Preview for chef-workstation processing.

Name	Link
🔨 Latest commit	c4c31e1ce27311fd32b838bedfad3b9505c60df6
🔍 Latest deploy log	https://app.netlify.com/sites/chef-workstation/deploys/67e5804e714b050008fa05f3

[Vasu1105]

@tas50 This will need chefstyle verify pipeline to be replace with cookstyle that is failing.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Vasu1105]

@tas50, based on my understanding and reviewing this PR https://github.com/chef/cookstyle/pull/969, it seems that in the rakefile, we only need to update the require "chefstyle" to require "cookstyle/chefstyle", and we don't need to add the --chefstyle option, which should resolve the pipeline issue and this PR will need DCO sign off

[Stromweld]

@tas50, based on my understanding and reviewing this PR chef/cookstyle#969, it seems that in the rakefile, we only need to update the require "chefstyle" to require "cookstyle/chefstyle", and we don't need to add the --chefstyle option, which should resolve the pipeline issue and this PR will need DCO sign off

@Vasu1105 if you don't use the --chefstyle flag it'll use different rules like prefering single quotes when not using interpolation in a string vs chefstyle rules prefer double quotes. --chefstyle was created to allow easy replacement of chefstyle gem but maintain the same expected output that chefstyle was giving for linting and allow for the introduction of new rubocop and liinting cops that come with the updates.

[Stromweld]

NVM I stand corrected. There was an update to make rakefiles easier to modify for existing repos to only need to modify the requires line. https://github.com/chef/cookstyle/pull/969 @Vasu1105 thanks for making me aware of that.

[tas50]

Feel free to update this as necessary. I'm not going to be able to update this myself given time constraints

[tas50]

Closing this out as the team can make these changes themselves