chef-workstation
chef-workstation copied to clipboard
Support running in windows terminal as a new tab and/or make ConEmu use optional
Describe the Enhancement:
I see that on windows there is explicit support for running with ConEmu if it's installed (regardless of whether I want it or not but that's an other point). I think similar support for Windows Terminal (the new terminal app from Windows) should be introduced
Describe the Need:
I suspect more and more Windows users will move towards using windows terminal. Currently I would just add my own windows terminal profile to run the chef workstation script or create a wrapper script so it runs in a new terminal tab. But because I have ConEmu also installed, it always just results in ConEmu being started and it running in that. I would like for check for Windows terminal first or add some kind of configuration to control how it starts up
Current Alternative
not really. The script always starts ConEmu. I could uninstall it, but ... Well I don't want toCan We Help You Implement This?:
I did try and I will continue to but I was hitting some issues with escaping arguments being passed to windows terminal. I'd also like to hear others opinions on this pattern of running in the emulator it's available regardless of user preference
This is a valid ask. Could you please share the branch name where you have pushed changes so we can discuss further?
For reference, the script under discussion is defined here[1], as the script that gets launched when someone launches Workstatoin PowerShell session
https://github.com/chef/chef-workstation/blob/mp/cobrify/omnibus/resources/chef-workstation/msi/assets/start-chefws.ps1
This is a valid ask. Could you please share the branch name where you have pushed changes so we can discuss further?
I haven't pushed a branch yet, just something I was playing with locally. I can try get something together to show. But I'm still not sure I'm a fan of just running in ConEmu (or any emulator) just because it's present. Really that should be something I configure don't you think?