chef-server icon indicating copy to clipboard operation
chef-server copied to clipboard

Distribution constant 15.x fixes

Open ramereth opened this issue 2 years ago • 5 comments

Description

Various changes were made in 15.x which broke many of our users due to some static linking to various paths. This PR works around much of this by using constants where it makes sense. Please let me know if you want me to refactor how I implement any of those. This also provides a fix for our users when migrating from 14.x to 15.x.

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or StackOverflow discussions that are relevant]

Check List

ramereth avatar Aug 04 '22 18:08 ramereth

Deploy Preview for chef-server processing.

Name Link
Latest commit 33e2bb317349962e1566bd343159fda36eaaa92c
Latest deploy log https://app.netlify.com/sites/chef-server/deploys/630d030cf8f72600089c0ad2

netlify[bot] avatar Aug 04 '22 18:08 netlify[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

sonarqubecloud[bot] avatar Aug 29 '22 18:08 sonarqubecloud[bot]

Thanks @ramereth. These changes look good, but we'll need to run this through our omnibus builds/test pipelines, which means creating an in-repo branch from these changes. We'll get that going this week.

marcparadise avatar Aug 30 '22 14:08 marcparadise

Looks okay, will need to be tested.

lbakerchef avatar Oct 17 '22 21:10 lbakerchef

See https://github.com/chef/chef-server/pull/3471

lbakerchef avatar Oct 17 '22 21:10 lbakerchef