automate icon indicating copy to clipboard operation
automate copied to clipboard

Jay/chef 11760-certificate rotation refactoring

Open jayvikramsharma1 opened this issue 1 year ago • 2 comments

:nut_and_bolt: Description: What code changed, and why?

:chains: Related Resources

:+1: Definition of Done

:athletic_shoe: How to Build and Test the Change

:white_check_mark: Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • [ ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • [ ] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • [ ] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • [ ] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • [ ] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • [ ] Tests added/updated? (all new code needs new tests)
  • [ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

:camera: Screenshots, if applicable

jayvikramsharma1 avatar Jul 03 '24 05:07 jayvikramsharma1

Deploy Preview for chef-automate processing.

Name Link
Latest commit c635499b5ddce9992c87634309449f3845101ac3
Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6698e527dbf2ed0008277638

netlify[bot] avatar Jul 03 '24 05:07 netlify[bot]

Quality Gate failed Quality Gate failed

Failed conditions
5 New issues
57.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint