chef_automate resource needs to set license property as a required

[wrightp]

license needs to be required because of the following line: https://github.com/chef-cookbooks/chef-ingredient/blob/master/resources/automate.rb#L69

[wrightp]

@ncerny Should license be required or should the files only be created if the property is set? I'm guessing the former.

[ncerny]

Well...in the spirit of not dictating how it gets there, I'd lean towards the later. But you're right, that line will fail if you don't specify it. I'm okay either way - because if it's required, we can always give the path to the file in the resource.

Thoughts? anything I'm not thinking of?

[wrightp]

Couple things: A) This resource won't work as it currently stands if not set B) This resources is a construct for properly installing Automate so it's not about dictating, it's about follow through.

We need to make these things consistent throughout the resources. We either guide users to configure their environments fully or we don't require configuration properties and code the resources to only configure what's set.