Fix for issue #537

[geoffles]

"Files in Machine Resources fail to copy on windows when copied to drive root"

Performs a check that the directory does not exist before creating it.

This has been tested against existing and non existing directories as well as root paths

[chef-supermarket]

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

[tyler-ball]

@geoffles Can you check if this is fixed by merging https://github.com/chef/chef-provisioning/pull/543 ? Now the transport should handle this for us.

[geoffles]

@tyler-ball I've replaced my ChefDK provisioning library with Master at the time of your message and am getting the following:

NameError: machine[testProv1] (mycookbook::myrecipe line 53) had an error: NameError: uninitialized constant WinRM::Connection
C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-provisioning-1.8.0/lib/chef/provisioning/transport/winrm.rb:104:in `session'
C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-provisioning-1.8.0/lib/chef/provisioning/transport/winrm.rb:42:in `block in execute'
C:/opscode/chefdk/embedded/lib/ruby/2.1.0/timeout.rb:90:in `block in timeout'
C:/opscode/chefdk/embedded/lib/ruby/2.1.0/timeout.rb:33:in `block in catch'
C:/opscode/chefdk/embedded/lib/ruby/2.1.0/timeout.rb:33:in `catch'
C:/opscode/chefdk/embedded/lib/ruby/2.1.0/timeout.rb:33:in `catch'
C:/opscode/chefdk/embedded/lib/ruby/2.1.0/timeout.rb:105:in `timeout'
C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-provisioning-1.8.0/lib/chef/provisioning/transport.rb:92:in `with_execute_timeout'
C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-provisioning-1.8.0/lib/chef/provisioning/transport/winrm.rb:40:in `execute'
C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-provisioning-1.8.0/lib/chef/provisioning/transport/winrm.rb:77:in `available?'
C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-provisioning-aws-1.10.0/lib/chef/provisioning/aws_driver/driver.rb:1308:in `wait_for_transport'
C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-provisioning-aws-1.10.0/lib/chef/provisioning/aws_driver/driver.rb:704:in `ready_machine'
C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-provisioning-1.8.0/lib/chef/provider/machine.rb:39:in `block in <class:Machine>'
...

Where Line 53 is just my machine resource.

It could be an authentication issue, since I also get this in the logs just before the failure (I've just redacted some privacy information):

[2016-09-12T07:18:10+02:00] INFO: Reading key demo-key from file C:/xxx\.ssh/demo-key.pem
[2016-09-12T07:18:10+02:00] INFO: [Aws::EC2::Client 200 0.261083 0 retries] get_password_data(instance_id:"i-xxx")

[2016-09-12T07:18:10+02:00] INFO: Reading key demo-key from file C:/xxx\.ssh/demo-key.pem
[2016-09-12T07:18:10+02:00] INFO: No SSL or no peer verification

Any Suggestions?