Include additional terminfo

[m4rcu5]

Would it be possible to bundle the terminfo files from ncurses-term as well? This would create support for the rxvt-unicode and rxvt-unicode-256color terminals.

Currently it results in:

No entry for terminal type "rxvt-unicode-256color";
using dumb terminal settings.
Available subcommands: (for details, knife SUB-COMMAND --help)

A workaround is to set the $TERMINFO variable to the local systems terminfo path.

[espoelstra]

I would like to see ChefDK get rid of tput infocmp et al from the the bin folders and use the system versions, but at this point I'm just using the chefdk Docker image as an "binary" type image and that keeps from from pulling my hair out when Chef doesn't have the latest terminfo files and breaks my scripts or SSH or other things when it doesn't recognize TERM=tmux-256color or rxvt et al.

[espoelstra]

This also affects the recently added tmux and tmux-256color options from a newer ncurses version.

I really wanted to get away from having to use screen or screen-256color and after making the changes, it worked on one machine, then failed on another and I discovered it was due to the ChefDK being earlier in the path and having it's own terminal definitions (in multiple places).

After some poking around I discovered that there are definitions at /opt/chefdk/embedded/lib/terminfo/ and /opt/chefdk/embedded/share/terminfo.

[afiune]

Thank you for filling in this issue, we do understand the problem you are describing but we would like to verify if this is still a problem you are facing? We have just verified with the latest version that the terminal type mentioned above works as expected:

bash-3.2$ echo $TERM
xterm-256color
bash-3.2$ knife -v
Chef Infra Client: 15.6.10
bash-3.2$ TERM="rxvt-unicode-256color" knife -v
Chef Infra Client: 15.6.10