pretty_face icon indicating copy to clipboard operation
pretty_face copied to clipboard

Prettyface out of date with Cucumber

Open Paul-Clewell opened this issue 10 years ago • 11 comments

Hey folks,

This is an issue we're picking up at a client, and after a bit of digging, I've found that the cucumber/ast references within the code is actually causing the project to fail spectacularly.

Not sure how to fix, but I did dig up that Ast was deprecated. Thought I'd point you in the right direction.

C:\Ruby200\bin\ruby.exe -e $stdout.sync=true;$stderr.sync=true;load($0=ARGV.shift) C:\Ruby200\bin/cucumber C:/Users/TNV766/Desktop/ICORE_Hispanic_Automation_Subversion/51.05_new/icoreAcceptanceTests/features/Hispanic_TellUs_About_Yourself_Dropdowns.feature --format Teamcity::Cucumber::Formatter --expand --color -r features -p st5 RDEE_BROWSER=firefox Testing started at 10:28 AM ... 0 scenarios 0 steps 0m0.000s NaN (ActionView::Template::Error) C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/lib/cucumber/formatter/duration.rb:8:in divmod' C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/lib/cucumber/formatter/duration.rb:8:informat_duration' C:/Ruby200/lib/ruby/gems/2.0.0/gems/pretty_face-0.10.2/lib/pretty_face/formatter/view_helper.rb:33:in scenario_average_duration' C:/Ruby200/lib/ruby/gems/2.0.0/gems/pretty_face-0.10.2/lib/pretty_face/templates/main.erb:53:in_____uby____lib_ruby_gems_______gems_pretty_face________lib_pretty_face_templates_main_erb___341596305_27652512' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/template.rb:145:in block in render' C:/Ruby200/lib/ruby/gems/2.0.0/gems/activesupport-4.1.6/lib/active_support/notifications.rb:161:ininstrument' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/template.rb:339:in instrument' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/template.rb:143:inrender' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/renderer/template_renderer.rb:55:in block (2 levels) in render_template' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/renderer/abstract_renderer.rb:38:inblock in instrument' C:/Ruby200/lib/ruby/gems/2.0.0/gems/activesupport-4.1.6/lib/active_support/notifications.rb:159:in block in instrument' C:/Ruby200/lib/ruby/gems/2.0.0/gems/activesupport-4.1.6/lib/active_support/notifications/instrumenter.rb:20:ininstrument' C:/Ruby200/lib/ruby/gems/2.0.0/gems/activesupport-4.1.6/lib/active_support/notifications.rb:159:in instrument' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/renderer/abstract_renderer.rb:38:ininstrument' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/renderer/template_renderer.rb:54:in block in render_template' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/renderer/template_renderer.rb:62:inrender_with_layout' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/renderer/template_renderer.rb:53:in render_template' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/renderer/template_renderer.rb:17:inrender' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/renderer/renderer.rb:42:in render_template' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/renderer/renderer.rb:23:inrender' C:/Ruby200/lib/ruby/gems/2.0.0/gems/actionview-4.1.6/lib/action_view/helpers/rendering_helper.rb:32:in render' C:/Ruby200/lib/ruby/gems/2.0.0/gems/pretty_face-0.10.2/lib/pretty_face/formatter/html.rb:171:ingenerate_report' C:/Ruby200/lib/ruby/gems/2.0.0/gems/pretty_face-0.10.2/lib/pretty_face/formatter/html.rb:140:in after_features' C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/lib/cucumber/ast/tree_walker.rb:181:inblock in send_to_all' C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/lib/cucumber/ast/tree_walker.rb:179:in each' C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/lib/cucumber/ast/tree_walker.rb:179:insend_to_all' C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/lib/cucumber/ast/tree_walker.rb:171:in broadcast' C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/lib/cucumber/ast/tree_walker.rb:20:invisit_features' C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/lib/cucumber/runtime.rb:49:in run!' C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/lib/cucumber/cli/main.rb:47:inexecute!' C:/Ruby200/lib/ruby/gems/2.0.0/gems/cucumber-1.3.17/bin/cucumber:13:in <top (required)>' C:/Ruby200/bin/cucumber:23:inload' C:/Ruby200/bin/cucumber:23:in <top (required)>' -e:1:inload' -e:1:in `

'

Process finished with exit code 1 Empty test suite.

Paul-Clewell avatar Oct 29 '14 17:10 Paul-Clewell

#35 is related. @cheezy if you'd like some help to get this gem working with Cucumber 2.0 just ping me and we can book some time to pair on it, or figure out how else we can help.

mattwynne avatar Mar 31 '15 21:03 mattwynne

I'm seeing this error as well. When I install and run PrettyFace on my laptop it's OK. When it runs on Jenkins I get the error above.

Locally I have pretty_face (0.10.3) and cucumber (1.3.17), on our Jenkins box its exactly the same. Yet the Jenkins job fails completely and the laptop runs OK.

JohnSmall avatar Apr 28 '15 13:04 JohnSmall

Hi @cheezy & @mattwynne. I just took note that @olleolleolle has been working to get Pretty_Face working with Cucumber 2.0.0+ and I was wondering if there is any chance of those changes (or something similar) being merged into master.

Pretty Face is the best reporting gem by a mile and I would love to see it back up to date.

azohra avatar Jun 20 '15 04:06 azohra

take my changes as dog-slapping-keyboard-until-it-kinda-works, please.

And, I had to give up, since I knew too little of the upcoming API.

The work with pretty_face taught me a lot about what a Formatter needs to function.

olleolleolle avatar Jun 20 '15 08:06 olleolleolle

That said, I also dig that more people want a modern pretty_face out there! Yay!

olleolleolle avatar Jun 20 '15 08:06 olleolleolle

How can I help?

mattwynne avatar Jun 22 '15 22:06 mattwynne

@mattwynne I made a "visualization PR" marked WIP, for the fixing of this thing.

olleolleolle avatar Jun 22 '15 22:06 olleolleolle

Looks like there was a fix to handle cucumber 2. Any chance this can get tagged for release so I can pull it with rubygems?

pittgoose avatar Sep 08 '15 13:09 pittgoose

when it will be fixed ?

timsheng avatar Dec 15 '15 06:12 timsheng

Hello, can we please have an update on this issue? Also, what is the latest version combo that does work? Thank you Jason Koelewyn

Githraine avatar Feb 11 '16 17:02 Githraine

Cucumber 1.3.20 + Latest release of Pretty Face.

If you are feeling inclined, I opened a code bounty which you could contribute to. Having made modifications myself, It is a significant amount of work to upgrade Pretty Face to work with cucumber 2.0

Big thanks to Jeff for all the work he has done so far.

azohra avatar Feb 11 '16 18:02 azohra